Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(registry-auth): scoped the legacy token in the npmrc to the registry #538

Closed
wants to merge 4 commits into from

Conversation

travi
Copy link
Member

@travi travi commented Dec 17, 2022

fixes #530

@travi
Copy link
Member Author

travi commented Dec 17, 2022

it looks like this only became scope-able to a registry in npm v8, so this would not be a backward compatible change for all of the node versions currently supported by this plugin.

since the official registry has not supported this legacy approach to auth for some time and registries other than the official registry require legacy auth to be scoped to a registry, this would only impact use with projects targeting alternative registries that are not yet using npm v8.

quite honestly, since artifactory was the primary reason that legacy auth support was added to semantic-release in the first place, and artifactory does now support token auth, i lean toward removing legacy auth support altogether rather than fixing it for npm v9.

@gr2m
Copy link
Member

gr2m commented Jan 7, 2023

since artifactory was the primary reason that legacy auth support was added to semantic-release in the first place, and artifactory does now support token auth, i lean toward removing legacy auth support altogether rather than fixing it for npm v9.

Agree 💯

@travi travi closed this Mar 31, 2023
@travi travi deleted the registry-auth branch March 31, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for npm v9
2 participants