Skip to content

Commit

Permalink
ci(dev-node): added a job to verify against the version in the .nvmrc…
Browse files Browse the repository at this point in the history
… intended for development

to help ensure all verification passes before deciding to update the development version (partly to
help automate this process with renovate)
  • Loading branch information
travi committed Sep 17, 2023
1 parent cdd67be commit 8f15f4b
Showing 1 changed file with 22 additions and 1 deletion.
23 changes: 22 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ permissions:
contents: read # to fetch code (actions/checkout)

jobs:
# verify against ranges defined as supported in engines.node
test_matrix:
strategy:
matrix:
Expand All @@ -40,11 +41,31 @@ jobs:
- run: npm audit signatures
- run: npm test

# verify against the node version defined for development in the .nvmrc
test_dev:
runs-on: ubuntu-latest
timeout-minutes: 5

steps:
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
- run: git config --global user.name github-actions
- run: git config --global user.email github-actions@github.com
- name: Use Node.js from .nvmrc
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3
with:
node-version-file: .nvmrc
cache: npm
- run: npm clean-install
- run: npm audit signatures
- run: npm test

# separate job to set as required in branch protection,
# as the build names above change each time Node versions change
test:
runs-on: ubuntu-latest
needs: test_matrix
needs:
- test_dev
- test_matrix
steps:
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
- uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3
Expand Down

0 comments on commit 8f15f4b

Please sign in to comment.