Skip to content

Commit

Permalink
feat(node-versions): raised the minimum node v20 requirement to v20.6
Browse files Browse the repository at this point in the history
for auto-registered loader support

BREAKING CHANGE: the minimum supported node version in the v20 major range is now v20.6
  • Loading branch information
travi committed Sep 16, 2023
1 parent a23b718 commit e623cc6
Show file tree
Hide file tree
Showing 5 changed files with 48 additions and 108 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Expand Up @@ -21,7 +21,7 @@ jobs:
matrix:
node-version:
- 18.17.0
- 20.0.0
- 20.6.0
- 20

runs-on: ubuntu-latest
Expand Down
141 changes: 40 additions & 101 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
Expand Up @@ -8,6 +8,7 @@
"files": [
"test/**/*.test.js"
],
"failFast": true,
"nodeArguments": [
"--loader=testdouble",
"--no-warnings"
Expand Down Expand Up @@ -72,10 +73,10 @@
"sinon": "16.0.0",
"stream-buffers": "3.0.2",
"tempy": "3.1.0",
"testdouble": "3.18.0"
"testdouble": "3.19.0"
},
"engines": {
"node": "^18.17 || >=20"
"node": "^18.17 || >=20.6"
},
"exports": "./index.js",
"files": [
Expand Down
2 changes: 1 addition & 1 deletion test/helpers/git-utils.js
Expand Up @@ -43,7 +43,7 @@ export async function initGit(withRemote) {
*
* @param {Boolean} withRemote `true` to create a shallow clone of a bare repository.
* @param {String} [branch='master'] The branch to initialize.
* @return {String} The path of the clone if `withRemote` is `true`, the path of the repository otherwise.
* @return {Promise<Object>} The path of the clone if `withRemote` is `true`, the path of the repository otherwise.
*/
export async function gitRepo(withRemote, branch = "master") {
let { cwd, repositoryUrl } = await initGit(withRemote);
Expand Down
6 changes: 3 additions & 3 deletions test/integration.test.js
Expand Up @@ -35,7 +35,7 @@ let env;

// Environment variables used only for the local npm command used to do verification
const npmTestEnv = {
...process.env,
...processEnvWithoutGitHubActionsVariables,
...npmRegistry.authEnv(),
npm_config_registry: npmRegistry.url,
};
Expand Down Expand Up @@ -516,8 +516,8 @@ test("Pass options via CLI arguments", async (t) => {
});

test("Run via JS API", async (t) => {
td.replace("../lib/logger", { log: () => {}, error: () => {}, stdout: () => {} });
td.replace("env-ci", () => ({ isCi: true, branch: "master", isPr: false }));
await td.replaceEsm("../lib/logger", null, { log: () => {}, error: () => {}, stdout: () => {} });
await td.replaceEsm("env-ci", null, () => ({ isCi: true, branch: "master", isPr: false }));
const semanticRelease = (await import("../index.js")).default;
const packageName = "test-js-api";
const owner = "git";
Expand Down

0 comments on commit e623cc6

Please sign in to comment.