Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple version determiner from npm registry #56

Closed
tlvince opened this issue Aug 17, 2015 · 7 comments
Closed

Decouple version determiner from npm registry #56

tlvince opened this issue Aug 17, 2015 · 7 comments
Assignees

Comments

@tlvince
Copy link
Contributor

tlvince commented Aug 17, 2015

Last release is currently determined by consulting the npm registry. As mentioned (out of band), this could be made more flexible by looking at Git tags (for example).

A use case for this could be in situations where the npm publish step is undesirable. This seems to resonate with some of the discussion in #51.

@juristr
Copy link

juristr commented Aug 17, 2015

👍

@boennemann
Copy link
Member

This is something I'd love to see. We could introduce another plugin hook "getLastRelease", leave the current implementation as default, and provide a git-tag based implementation.

Anyone up for tackling this one?

@ariporad
Copy link
Contributor

ariporad commented Aug 17, 2015 via email

@boennemann
Copy link
Member

@ariporad This sounds fantastic, do you want to chat about it some more on gitter first?

@boennemann
Copy link
Member

Alright, @ariporad will take a stab at implementing this 👍

  1. Add a "getLastRelease" plugin hook to semantic-release
  2. Move lib/last-release.js to https://github.com/semantic-release/last-release-npm and make it the default
  3. Implement https://github.com/semantic-release/last-release-git-tag

🎉

ariporad added a commit to ariporad/semantic-release that referenced this issue Aug 17, 2015
Move getLastRelease into it's very own plugin (@semantic-release/last-release-npm),
which this project now depends on.

BREAKING CHANGE: Remove npmTag from output of getLastRelease. It wasn't used anywhere.
Refs semantic-release#56, semantic-release#51
@ariporad
Copy link
Contributor

Number 1 is fixed in #57.

@tlvince
Copy link
Contributor Author

tlvince commented Aug 18, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants