Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative trigger options #1471

Merged
merged 3 commits into from May 6, 2020
Merged

Conversation

abatilo
Copy link
Contributor

@abatilo abatilo commented Feb 21, 2020

These options work the same as the curl command, but use a GitHub App so there's no need to provision and manage a Personal Access Token in order to trigger the Semantic Release action.

Full disclosure, I'm personally involved with Actions Panel. Not involved at all with Action Button.

These options work the same as the curl command, but use a GitHub App so there's no need to provision and manage a Personal Access Token in order to trigger the Semantic Release action.
@pvdlg
Copy link
Member

pvdlg commented Feb 24, 2020

The goal of semantic-release is to help releasing any code change as soon as possible, which is why we recommend to run it on each push.
The solution that you mention might be useful for certain semantic-release users but I don't know if we want to recommend those as it goes against what we recommend everywhere else.
@gr2m any thoughts on that?

@abatilo
Copy link
Contributor Author

abatilo commented Feb 24, 2020

If it's of any value, I have work projects where we don't release every time we merge because we have specific deploy days.

It feels like you lose some of the magic of using semantic-release when every release only has one note in it, versus having many stock piled.

@abatilo
Copy link
Contributor Author

abatilo commented Apr 5, 2020

@pvdlg @gr2m Following up on this thread. Any other thoughts?

Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find that quite interesting, I don't mind adding that, some users might find it useful (I could see myself using it in some circumstances), and it's the right place to inform GItHub Actions users about it.

@gr2m gr2m merged commit a62bc7c into semantic-release:master May 6, 2020
@semantic-release-bot
Copy link
Collaborator

🎉 This PR is included in version 17.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

aquariuslt pushed a commit to aquariuslt/semantic-release that referenced this pull request Sep 15, 2020
…se#1471)

These options work the same as the curl command, but use a GitHub App so there's no need to provision and manage a Personal Access Token in order to trigger the Semantic Release action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants