Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: escape uri encoded symbols #1697

Merged
merged 1 commit into from Nov 19, 2020
Merged

fix: escape uri encoded symbols #1697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/hide-sensitive.js
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@ module.exports = (env) => {
});

const regexp = new RegExp(
toReplace.map((envVar) => `${escapeRegExp(env[envVar])}|${encodeURI(escapeRegExp(env[envVar]))}`).join('|'),
toReplace.map((envVar) => `${escapeRegExp(env[envVar])}|${escapeRegExp(encodeURI(env[envVar]))}`).join('|'),
'g'
);
return (output) =>
Expand Down
8 changes: 8 additions & 0 deletions test/hide-sensitive.test.js
View file
Open in desktop
Expand Up @@ -40,6 +40,14 @@ test('Escape regexp special characters', (t) => {
);
});

test('Escape regexp special characters in url-encoded environment variable', (t) => {
const env = {SOME_PASSWORD: 'secret password p$^{.+}\\w[a-z]o.*rd)('};
t.is(
hideSensitive(env)(`https://user:${encodeURI(env.SOME_PASSWORD)}@host.com`),
`https://user:${SECRET_REPLACEMENT}@host.com`
);
});

test('Accept "undefined" input', (t) => {
t.is(hideSensitive({})(), undefined);
});
Expand Down