fix: support windows absolute extends

[sheerlox]

Description

Restore support for Windows absolute path in the extends configuration option by using import-from-esm to load the referenced module.

Context

Following the changes in #3037, a user encountered an ERR_UNSUPPORTED_ESM_URL_SCHEME error because using resolve-from does not return an URL, and import then considers C:/ to be an URL scheme (like file://) and returns the encountered error.

How has this been tested

Since there are no Windows-specific tests on this repository and the test pipeline doesn't run on Windows, we can rely on import-from-esm solid test suite to guarantee this works:

• all tests importing local files are run against both relative & absolute paths, and the test pipeline runs on Ubuntu, Windows & MacOS
• importing extensionless / index.json & package main entry point JSON modules is now supported and covered by tests

Related issues

• Support extending ESM based configurations #3037 (comment)
• feat: add support for ESM presets commit-analyzer#537 (comment)
• fix: support windows absolute paths sheerlox/import-from-esm#40
• feat: support index, main and extensionless JSON modules sheerlox/import-from-esm#51

[travi]

just one thought wondering if we could clean things up furhter. i havent dug in to better understand if that is a reasonable follow up or not, but i'm going to move this forward and we can do that as a separate PR if it does make sense.

thanks for sticking with this @sheerlox!

[travi]

is resolve-from still used elsewhere in the project? would it be possible to remove it as a dependency?

[sheerlox]

Yes it is still being used in the loadPlugin function, and we can't replace it with import-from-esm it because doesn't support ESM named exports (it only returns the whole module if the default export does not exist).
At least this part of the code is not subject to the Windows absolute path issue since the import statement explicitly specifies the file:// protocol.

semantic-release/lib/plugins/utils.js

Lines 50 to 67 in d3aae07

	export async function loadPlugin({ cwd }, name, pluginsPath) {
	const basePath = pluginsPath[name]
	? dirname(resolveFrom.silent(__dirname, pluginsPath[name]) || resolveFrom(cwd, pluginsPath[name]))
	: __dirname;
	if (isFunction(name)) {
	return name;
	}
	const file = resolveFrom.silent(basePath, name) || resolveFrom(cwd, name);
	const { default: cjsExport, ...esmNamedExports } = await import(`file://${file}`);
	if (cjsExport) {
	return cjsExport;
	}
	return esmNamedExports;
	}

[github-actions]

🎉 This PR is included in version 22.0.8 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀