Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use spawn instead of exec for 'git log' to avoid maxBuffer err #332

Merged
merged 2 commits into from
Nov 28, 2016
Merged

fix: use spawn instead of exec for 'git log' to avoid maxBuffer err #332

merged 2 commits into from
Nov 28, 2016

Conversation

bengummer
Copy link
Contributor

Related to #286

Uses child_process.spawn instead of child_process.exec, as exec has a fixed maxBuffer.

Only converted git log to use the new spawn method to reduce PR complexity and git log seems like the main culprit for maxBuffer errors.

@boennemann boennemann merged commit 73138f8 into semantic-release:caribou Nov 28, 2016
@boennemann
Copy link
Member

Thank you 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants