Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verify stage when specify path #197

Merged
merged 5 commits into from
Jan 18, 2024

Conversation

AntoninoBonanno
Copy link
Contributor

@AntoninoBonanno AntoninoBonanno commented Dec 25, 2023

I fixed the verify stage (both for the theme and for the plugin) in case the path is specified from the configuration, Resolve #159 .

I also added "path" in the README.md as I believe it is a useful feature when your code is in a subdirectory or is generated by Webpack as in my case

Basically I standardized the use of the "path" configuration in the "verify", "prepare", "publish" stages.

Before:

await verifyConditions(
{
type: 'theme',
slug: 'complete-theme',
path: './test/fixtures',
},
context,
),

await prepare(
{
type: 'theme',
slug: 'complete-theme-copy',
path: './test/fixtures/complete-theme-copy',
copyFiles: false,
withVersionFile: true,
withAssets: true,
versionFiles: ['functions.php'],
include: ['style.css', '*.php', 'vendor'],
exclude: [],
workDir: '1',
},
context,
);

const pluginConfig: PluginConfig = {
type: 'plugin',
slug: 'dist-test',
path: './test/fixtures/dist-test',
withAssets: true,
withReadme: true,
include: ['dist-test.php', './*.php', 'vendor'],
exclude: [],
withVersionFile: true,
workDir: 'publish',
};

After:

async () =>
await verifyConditions(
{
type: 'theme',
slug: 'complete-theme',
path: './test/fixtures/complete-theme',
},
context,
),

Copy link
Member

@seebeen seebeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's sort out the dependency bumps in the commit - and we can merge then.

Awseome work, btw. Much appreciated.

package.json Outdated Show resolved Hide resolved
Copy link
Member

@seebeen seebeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 💪

@seebeen
Copy link
Member

seebeen commented Jan 17, 2024

Hey, I just saw that none of the commits are GPG signed. Would it be too much of a hassle to setup GPG on your end.

After that, you can use this guide To retroactively sign your commits in this PR.

Reason the GPG signing is enforced in this repo is to prevent potential supply chain attacks.
WordPress powers >45% of all the websites in the world so the poential impact of supply chain poisoning is immense.

@AntoninoBonanno
Copy link
Contributor Author

ready

@seebeen seebeen merged commit eaac11e into semantic-release:master Jan 18, 2024
4 checks passed
Copy link

🎉 This PR is included in version 1.5.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants