-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix verify stage when specify path #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's sort out the dependency bumps in the commit - and we can merge then.
Awseome work, btw. Much appreciated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good 💪
Hey, I just saw that none of the commits are GPG signed. Would it be too much of a hassle to setup GPG on your end. After that, you can use this guide To retroactively sign your commits in this PR. Reason the GPG signing is enforced in this repo is to prevent potential supply chain attacks. |
This reverts commit e4f0e0c.
13eedf0
to
380fe63
Compare
ready |
🎉 This PR is included in version 1.5.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I fixed the verify stage (both for the theme and for the plugin) in case the path is specified from the configuration, Resolve #159 .
I also added "path" in the README.md as I believe it is a useful feature when your code is in a subdirectory or is generated by Webpack as in my case
Basically I standardized the use of the "path" configuration in the "verify", "prepare", "publish" stages.
Before:
wordpress/test/1-verify-theme.spec.ts
Lines 90 to 97 in e8b42e5
wordpress/test/2-prepare-theme.spec.ts
Lines 95 to 109 in e8b42e5
wordpress/test/3-publish-plugin.spec.ts
Lines 12 to 22 in e8b42e5
After:
wordpress/test/1-verify-theme.spec.ts
Lines 89 to 97 in 5cfb7e8