This repository has been archived by the owner on Nov 13, 2021. It is now read-only.
Project has no remote #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schultyy
force-pushed
the
project-has-no-remote
branch
from
a05cf52
to
bbcff34
Compare
| @@ -134,10 +134,10 @@ pub fn tag(config: &Config, tag_name: &str, tag_message: &str) -> Result<(), Err | |||
|
|
|||
| pub fn push(config: &Config, tag_name: &str) -> Result<(), Error> { | |||
| let repo = &config.repository; | |||
| let token = config.gh_token.as_ref().unwrap(); | |||
| let token = &config.gh_token.as_ref().unwrap(); | |||
There was a problem hiding this comment.
Because we're using .as_ref here, we already get a &String from that unwrap, we don't need to take another reference on that (with your code token is a &&String, which causes no problems, because it derefs to &str later in either case)
|
Left some comments. Otherwise LGTM. |
added 4 commits
April 17, 2016 11:48
schultyy
force-pushed
the
project-has-no-remote
branch
from
bc56563
to
a9c2a69
Compare
| cd has-no-remote | ||
| setup_dirs | ||
|
|
||
| run CARGO_TOKEN=1234 semantic-rs -w |
There was a problem hiding this comment.
CARGO_TOKEN=1234 run semantic-rs -w should work
schultyy
force-pushed
the
project-has-no-remote
branch
from
a9c2a69
to
88e4818
Compare
schultyy
force-pushed
the
project-has-no-remote
branch
from
88e4818
to
efad562
Compare
|
@not-A-robot r+ |
|
@not-A-robot r+ |
|
📌 Commit efad562 has been approved by |
ghost
pushed a commit
that referenced
this pull request
Apr 26, 2016
Project has no remote PR for #73 This PR handles the case if the project has no remote configured. Before semantic-rs just failed with an error now it's printing a warning to notify the user of the things that do not happen. Since that case is not an error but something with a bit more relevance than just info the logger got a `warn` function for that case.
|
☀️ Test successful - status-travis |
ghost
merged commit 
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #73
This PR handles the case if the project has no remote configured. Before semantic-rs just failed with an error now it's printing a warning to notify the user of the things that do not happen.
Since that case is not an error but something with a bit more relevance than just info the logger got a
warnfunction for that case.