Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with gist:Room #102

Closed
rjyounes opened this issue Aug 21, 2019 · 12 comments
Closed

Problems with gist:Room #102

rjyounes opened this issue Aug 21, 2019 · 12 comments
Assignees
Labels
status: deferred to major release Involves a major change so deferred till next major release. An implementation may be specified. status: under review In triage

Comments

@rjyounes
Copy link
Collaborator

rjyounes commented Aug 21, 2019

The term specification does not define a "room" in the ordinary sense: e.g., elevators, staircases, hallways, and closets are direct parts of buildings but not rooms in the ordinary sense; and they can all have IDs. Also, a room in the ordinary sense can be a direct part of a wing, where the wing is a direct part of a building. In this case the room is a part of the building but not a direct part. According to the gist definition of Room, the wing is a Room and the room within a wing is not a Room. We could rename the class, but the usefulness of a class that includes elevators, staircases, hallways, wings, and some rooms but not others, is dubious; this is confirmed by the difficulty of finding an accurate name for the class - i.e., it's not a real concept. I suggest modifying the definition of gist:Room to be a semantically and coherent reflection of the concept of "room."

@johnwcowan
Copy link

This is an instance of the directPart general problem. Is a finger a direct part of a human body, or is it part of a hand which may be (depending on the natural language) part of an arm which is part of a body?

Both ordering and hierarchy need better general approaches.

@rjyounes
Copy link
Collaborator Author

  1. Remove restriction on gist:identifiedBy
  2. Change directPart Building to part Building
  3. Change definition. Bring back proposals to group.

@rjyounes rjyounes added effort: small Requires less than one day to complete impact: patch No new functionality or changes in human-readable semantics (e.g,. fixing a typo in an annotation) status: under review In triage status: triaged labels Jun 11, 2020
@johnwcowan
Copy link

johnwcowan commented Jun 11, 2020 via email

@rjyounes
Copy link
Collaborator Author

@johnwcowan I agree. Can you please add an issue?

@rjyounes
Copy link
Collaborator Author

@johnwcowan Never mind. We have an issue #115 which includes this.

@johnwcowan
Copy link

johnwcowan commented Jun 11, 2020 via email

@ungricht
Copy link

Problem statement: “Room” is an ambiguous label. There are problems with polysemy, and so simply fixing the definition for “Room” isn’t going to solve the issue. If we consider the concepts that share the label “Room” we find multiple distinctions that are significant (e.g. Space vs Place, physical space vs virtual space, etc.). These may need to be accommodated in Gist.

Proposal: It seems like there’s an implicit class in between “PhysicalIdentifiableItem” and “Building.” That class is something like “Structure.” This could rely on “hasDirectPart” to refer to other structures, though “locatedIn” is more accurate. Additionally, you could create a subclass of “Structure” that is a variant of “Partition”(PartitionedSpace/BuildingPartition) to indicate that a partition might be different from the structure of which it is a part. “Partition” could be defined to have a function, and it’s instances (or types) could include some of the edge case examples we discussed: stairwell, office, section of seating in an arena, assigned desk/cubicle. If you wanted “Building” to be a “PhysicalIdentifiableItem” with all the associated properties, you could create a subclass of “Structure” that is “PhysicalStructure” or “Building” but “PhysicalStructure” might be able to include things like Mount Rushmore or Half Dome.
It doesn’t have to be a physical structure; it could be a data structure or a virtual structure (Minecraft). One example is having a Zoom meeting, or a virtual meeting where there’s a shared ID for a virtual space and several participants join. It’s less clear from the problem statement that we need to accommodate such a case with this model, but it doesn’t appear to break it.

image

@ungricht
Copy link

And looking back, there's also a problem with "directPart" but that is also resolved by the proposed approach, because I recommend using "locatedIn" which is a property we've used with some success with our clients.

@uscholdm
Copy link
Contributor

uscholdm commented Jul 1, 2020

@ungricht makes some good points. A few comments.

  1. The term 'Structure' is super-ambiguous, use it at all will be difficult to get right.
  2. We need to focus on what is likely to be needed in practice for the typical enterprise. Room does not come up very often. Once for Sentara for where to store medical supplies. I had a lot of detail and generality about the notion of place. It was my first SA ontology and it was way over-complicated.
  3. We can stick with @rjyounes 's proposal and move on, until/unless we have use cases.

@rjyounes
Copy link
Collaborator Author

rjyounes commented Jul 9, 2020

Should this be in gist at all?

PartitionedSpace is not a subclass of Structure.

Because we can't agree on a common meaning and use of Room, this suggests that it should not be defined in gist.

DECISION: Remove it.

Deprecating, moving to gistDeprecated.

@rjyounes rjyounes added status: implementation specified Implementation has been specified. A developer should be assigned. impact: minor New, backward-compatible functionality (does not change inferences; e.g., adding a term) and removed status: under review In triage labels Jul 9, 2020
@rjyounes rjyounes assigned rjyounes and unassigned ungricht Jul 10, 2020
@rjyounes
Copy link
Collaborator Author

@ungricht I've devoted some time to gist today, so I'll take this on since it's so quick.

@rjyounes rjyounes added status: under review In triage and removed status: implementation specified Implementation has been specified. A developer should be assigned. impact: minor New, backward-compatible functionality (does not change inferences; e.g., adding a term) impact: patch No new functionality or changes in human-readable semantics (e.g,. fixing a typo in an annotation) labels Jul 10, 2020
@rjyounes rjyounes added the status: deferred Deferred to a later release for reasons other than it is a major change label Aug 13, 2020
@rjyounes rjyounes added closed: duplicate Duplicate issue or subsumed by another issue status: triaged status: deferred Deferred to a later release for reasons other than it is a major change and removed effort: small Requires less than one day to complete status: under review In triage status: triaged status: deferred Deferred to a later release for reasons other than it is a major change closed: duplicate Duplicate issue or subsumed by another issue labels Aug 13, 2020
@rjyounes
Copy link
Collaborator Author

DEFERRED: See comments on PR #335

@rjyounes rjyounes added the status: implementation specified Implementation has been specified. A developer should be assigned. label Aug 13, 2020
@rjyounes rjyounes added status: deferred to major release Involves a major change so deferred till next major release. An implementation may be specified. and removed status: deferred Deferred to a later release for reasons other than it is a major change status: implementation specified Implementation has been specified. A developer should be assigned. labels Oct 22, 2020
@rjyounes rjyounes added the status: under review In triage label Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: deferred to major release Involves a major change so deferred till next major release. An implementation may be specified. status: under review In triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants