Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend unit of measure symbol predicates to things other than units of measure #531

Closed
rjyounes opened this issue Aug 16, 2021 · 4 comments · Fixed by #997
Closed

Extend unit of measure symbol predicates to things other than units of measure #531

rjyounes opened this issue Aug 16, 2021 · 4 comments · Fixed by #997
Assignees
Labels
effort: small Requires less than one day to complete impact: minor New, backward-compatible functionality (does not change inferences; e.g., adding a term)

Comments

@rjyounes
Copy link
Collaborator

Currently we have three symbol-related datatype properties with domain UnitOfMeasure:

unitSymbol
unitSymbolHtml # as of 10.0.0
unitSymbolUnicode

The proposal is to extend the predicates to apply to anything, since things other than units of measure may have symbols, such as chemical compounds (this could have been relevant to one of my past clients). Thus:

symbol
symbolHtml
symbolUnicode

and modify skos:definition accordingly. We can include domainIncludes gist:UnitOfMeasure to indicate that one usage pertains to units of measure.

@rjyounes rjyounes changed the title UnitOfMeasure symbol predicates Extend intended usage of unit of measure symbol predicates Aug 16, 2021
@rjyounes rjyounes changed the title Extend intended usage of unit of measure symbol predicates Extend unit of measure symbol predicates to things other than units of measure Aug 16, 2021
@uscholdm uscholdm added priority: nice to have Low priority feature or bug fix impact: minor New, backward-compatible functionality (does not change inferences; e.g., adding a term) effort: small Requires less than one day to complete topic: units and measures labels Sep 12, 2023
@uscholdm
Copy link
Contributor

@rjyounes This makes sense to me.

@rjyounes rjyounes removed priority: nice to have Low priority feature or bug fix topic: units and measures labels Oct 26, 2023
@rjyounes
Copy link
Collaborator Author

DECISION: Add three predicates, deprecate existing ones

@uscholdm
Copy link
Contributor

DECISION: Add three predicates, deprecate existing ones

If we decided to do this, why did we just create #992
See also #959, #579

@rjyounes
Copy link
Collaborator Author

rjyounes commented Oct 27, 2023

I see the confusion. #992 should be entitled "Deprecate gist:symbolHtml and gist:symbolUnicode once the names have been changed." I'll clarify that. I agree it seems weird on the face of it to have one issue to rename predicates and another to delete them, but it actually makes sense in this context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: small Requires less than one day to complete impact: minor New, backward-compatible functionality (does not change inferences; e.g., adding a term)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants