Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit hook not running #794

Closed
rjyounes opened this issue Feb 21, 2023 · 2 comments · Fixed by #795
Closed

pre-commit hook not running #794

rjyounes opened this issue Feb 21, 2023 · 2 comments · Fixed by #795
Assignees

Comments

@rjyounes
Copy link
Collaborator

rjyounes commented Feb 21, 2023

PR #788 may have introduced a bug whereby the pre-commit is no longer running. I thought I had tested the change to rdf-toolkit.jar both manually, by running serialize.sh, and as a pre-commit hook, and everything was working at the time I merged to develop.

@stevenchalem Would you mind having a look by trying to commit a file on a branch that has a syntax error? This is how I found just now that it wasn't running.

@Jamie-SA
Copy link
Contributor

@rjyounes I am working on a PR to add a feature to the pre-commit hook and it would change things slightly. I can test that if you want and create a fix if needed.

@rjyounes
Copy link
Collaborator Author

rjyounes commented Feb 21, 2023

OK, thanks. Note that I moved the files into /tools/serializer/ rather than /tools/ - in case you missed my email to that effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants