Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rdf-toolkit.jar to version 1.14.2 to suppress NamedIndividual assertions. Fixes #774. #788

Merged
merged 4 commits into from Feb 10, 2023

Conversation

rjyounes
Copy link
Collaborator

@rjyounes rjyounes commented Feb 1, 2023

@uscholdm Please test this in two ways and let me know if you have any questions or problems:

  1. Run manually. Note that the serialization files have moved from tools to tools/serializer. Then revert the ttl files to test the pre-commit hook (step 2).
  2. Copy the modified pre-commit hook into .git/hooks, make a small change so that a commit is executed, and make sure the pre-commit hook removes the NamedIndividual assertions in the ttl files.

…reate subdirectory of tools for serialization files; concomitant changes to pre-commit hook and serialize script
@uscholdm
Copy link
Contributor

uscholdm commented Feb 2, 2023 via email

@rjyounes
Copy link
Collaborator Author

rjyounes commented Feb 2, 2023

Why do you want to do a commit before serializing? That means if someone diffs that commit against the preceding, they will get noise. That defeats the purpose.

@uscholdm
Copy link
Contributor

uscholdm commented Feb 2, 2023

Why do you want to do a commit before serializing?

I don't know how to explain it differently in a way that will be easier to understand.

That means if someone diffs that commit against the preceding, they will get noise.

No, it makes it easier to see what the actual changes were in cases where serializing jumbles things all up, which is quite common. The idea is to do two commits one right after the other. The first commit makes it easy to see what the actual differences are, the second commit is for all future development. The second commit (serialize only) makes it obvious how much the serializer jumbles things up.

@rjyounes rjyounes removed the request for review from uscholdm February 10, 2023 12:16
@rjyounes rjyounes merged commit bb9befd into develop Feb 10, 2023
@rjyounes rjyounes deleted the feature/issue744_rdf-toolkit_upgrade branch February 10, 2023 12:17
@Jamie-SA Jamie-SA mentioned this pull request Apr 19, 2023
26 tasks
@rjyounes rjyounes changed the title Upgrade rdf-toolkit.jar to version 1.14.2 to suppress NamedIndividual assertions. Fixes #744. Upgrade rdf-toolkit.jar to version 1.14.2 to suppress NamedIndividual assertions. Fixes #774. May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants