Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes and other documentation files in the release package render poorly in HTML #923

Closed
rjyounes opened this issue Jul 9, 2023 · 6 comments · Fixed by #928
Closed
Assignees
Labels
area: documentation priority: must have Required feature or bug fix; highest priority status: under review In triage type: bug

Comments

@rjyounes
Copy link
Collaborator

rjyounes commented Jul 9, 2023

In particular, there is no indentation of bullet points, which is highly problematic.

This could be entirely an onto_tool issue, but I've added the issue here because it is creating a problem in gist.

If this could be fixed before the next release I propose that we serve up the corrected version on the website and possibly slip the file into the download (or does the latter require a patch release?)

@rjyounes
Copy link
Collaborator Author

rjyounes commented Jul 9, 2023

Fix with #924.

@bpelakh
Copy link
Contributor

bpelakh commented Jul 10, 2023

There have been some issues with the Python package used to convert Markdown to HTML during the build, especially around nested lists. It also appears, as seen in the most recent release notes, that tables don't render correctly. We can look into upgrading the rendering package.

In the past, I've had to mess around with the Markdown to make sure the HTML rendered properly. It should be the responsibility of the release manager to run the build and double-check that documents look OK after the export.

@rjyounes
Copy link
Collaborator Author

I've had to mess around with the Markdown to make sure the HTML rendered properly

Can you provide some guidance on how to patch the Markdown so that we don't have to edit the HTML directly? You could add instructions under item 11 here: https://semarts.atlassian.net/wiki/spaces/OF/pages/1126760539/gist+Release+Management+Ontologists.

@rjyounes rjyounes changed the title Release notes render poorly in HTML Release notes and other documentation files in the release package render poorly in HTML Jul 10, 2023
@rjyounes rjyounes added type: bug priority: must have Required feature or bug fix; highest priority area: documentation labels Jul 10, 2023
@rjyounes rjyounes assigned bpelakh and unassigned sa-bpelakh Jul 10, 2023
@Jamie-SA
Copy link
Contributor

Maybe there are better converters out there.

@rjyounes
Copy link
Collaborator Author

Strange that the bulleted list works in the MajorVersionMigration file.

@sa-bpelakh sa-bpelakh linked a pull request Jul 18, 2023 that will close this issue
sa-bpelakh added a commit that referenced this issue Jul 19, 2023
Add newline to property format HTML table. Fixes #923
@Jamie-SA
Copy link
Contributor

I think this should have been closed when #928 & #923 where merged & closed, except that the "fixes" and "resolves" hints only work on the default branch, not on our release branches. I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation priority: must have Required feature or bug fix; highest priority status: under review In triage type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants