Fix typo in scope note for _percent
#971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjyounes
requested changes
Sep 15, 2023
| @@ -0,0 +1,3 @@ | |||
| ### Patch Updates | |||
|
|
|||
| - Fixed typo in scope note for `gist:_percent`: changed 'dimensional' to 'dimensionless'. Issue [#961](https://github.com/semanticarts/gist/issues/961). | |||
There was a problem hiding this comment.
I think this is overkill. We should probably say something like "Made various minor wording corrections to annotations." In the 12.0.0 release notes we said
I'm not sure how to do this with our new approach of using separate files for release notes. Perhaps you could add a note for the release manager on adding similar items to the list of issues without specifying the particular fix in each case.
rjyounes
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #961