Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semaphore CLI #191

Merged
merged 19 commits into from
Dec 16, 2022
Merged

Semaphore CLI #191

merged 19 commits into from
Dec 16, 2022

Conversation

cedoor
Copy link
Member

@cedoor cedoor commented Dec 15, 2022

Description

Setting up a project, although not particularly complex, can be a lengthy process for some people. A command line to initialize a Semaphore project can reduce the set-up time from a few minutes to a few seconds. The command line can also be useful for obtaining the data of groups deployed on the networks supported by Semaphore.

This PR adds a new @semaphore-protocol/cli package which can be used to initialize Semaphore projects and get groups' data. It also includes a mechanism to dynamically download templates as NPM packages. There is currently only one template (@semaphore-protocol/cli-template-hardhat), but new ones can be integrated in the future.

Related Issue

Closes #182

Does this introduce a breaking change?

  • Yes
  • No

@cedoor cedoor added the feature 🚀 This is enhancing something existing or creating something new label Dec 15, 2022
@cedoor cedoor added this to the Semaphore Protocol v3 milestone Dec 15, 2022
@cedoor cedoor self-assigned this Dec 15, 2022
@cedoor cedoor linked an issue Dec 15, 2022 that may be closed by this pull request
Copy link
Contributor

@sripwoud sripwoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could successfully run all the operations of the CLI 👌

I suggest looking at https://github.com/SBoudrias/Inquirer.js
That way the cli is more interactive and more "fool proof" because you control better what the user can choose

packages/cli/src/index.ts Show resolved Hide resolved
packages/cli/src/index.ts Outdated Show resolved Hide resolved
packages/cli/src/index.ts Show resolved Hide resolved
packages/cli/src/index.ts Show resolved Hide resolved
@cedoor
Copy link
Member Author

cedoor commented Dec 16, 2022

I could successfully run all the operations of the CLI ok_hand

I suggest looking at https://github.com/SBoudrias/Inquirer.js That way the cli is more interactive and more "fool proof" because you control better what the user can choose

Yep, it looks cool. We can definitely use Inquirer as soon as we'll have more templates in the init command! I'll create a separate issue. Thanks 🙏🏽

@cedoor cedoor merged commit 85af25a into dev Dec 16, 2022
@cedoor cedoor deleted the feat/semaphore-cli branch December 16, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🚀 This is enhancing something existing or creating something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semaphore CLI
2 participants