Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New class parameter to add members #322

Merged
merged 1 commit into from
May 15, 2023
Merged

New class parameter to add members #322

merged 1 commit into from
May 15, 2023

Conversation

cedoor
Copy link
Member

@cedoor cedoor commented May 15, 2023

Description

This PR adds a third parameter to the Group class, that can be used to initialize a list of member. It is more efficient than the old addMembers method, which is now deprecated. Times are now about 10 times faster.

Related Issue

Closes #319

Does this introduce a breaking change?

  • Yes
  • No

@cedoor cedoor added feature 🚀 This is enhancing something existing or creating something new Performance 📈 A code change that improves the performance labels May 15, 2023
@cedoor cedoor requested a review from vplasencia May 15, 2023 11:50
@cedoor cedoor linked an issue May 15, 2023 that may be closed by this pull request
@cedoor cedoor merged commit 5915ea0 into dev May 15, 2023
3 checks passed
@cedoor cedoor deleted the feat/init-members branch May 15, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🚀 This is enhancing something existing or creating something new Performance 📈 A code change that improves the performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Efficiently bulk-add members to Semaphore Group
2 participants