ci: fix circom deps installation steps #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sripwoud
changed the title
|
So we could consider always skipping their repo in the ci? |
sripwoud
added
bug 🐛
cedoor
approved these changes
Apr 24, 2024
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Semaphore Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The circom deps in the pull requests workflow can't be install because there is an issue with their ubuntu repository (probably a temporary issue on the microsoft side related to their GPG keys).
As a temporary fix we can simply delete the microsoft source file in the workflow environment.
Besides, as long as the integrity checks of the packages we get from the microsoft repo are broken, I think it is fine to not fetch packages from their repo at all.
The drawback of not getting their softwares updates does not matter so much for us, as this is a ci environment we just use for running tests.
https://github.com/orgs/community/discussions/120966
https://stackoverflow.com/a/78377916