Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add code owners #784

Merged
merged 1 commit into from
May 15, 2024
Merged

chore: add code owners #784

merged 1 commit into from
May 15, 2024

Conversation

cedoor
Copy link
Member

@cedoor cedoor commented May 15, 2024

Description

Through Github rulesets and the definition of code owners, it is possible to automate the review process without additional workflows. It also makes responsibilities within the project clearer. The current CODEOWNERS file is very simple but more complex rules can be introduced in the future.

Related Issue(s)

Closes #783

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cedoor
chore: add code owners
f20627c 
Through Github rulesets and the definition of code owners, it is possible to automate the review
process without additional workflows. It also makes responsibilities within the project clearer. The
current CODEOWNERS file is very simple but more complex rules can be introduced in the future.

re #783
@cedoor cedoor requested a review from a team May 15, 2024 12:36
@cedoor cedoor merged commit ea175fa into main May 15, 2024
5 checks passed
@cedoor cedoor deleted the chore/codeowners branch May 15, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xjei 0xjei 0xjei approved these changes

@vplasencia vplasencia vplasencia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CODEOWNERS file
3 participants
@cedoor @0xjei @vplasencia