Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deploy contracts and replace mumbai with amoy #809

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

cedoor
Copy link
Member

@cedoor cedoor commented Jun 27, 2024

Description

This PR deploys the latest version of the contracts and replaces Polygon Mumbai (deprecated) with Amoy.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@sripwoud sripwoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How were all the contracts deployed?
Isn't the README in packages/contracts outdated? It refers to a deploy:semaphore script but I don't see it defined in packages/contracts/package.json.
I see there is a deploy:semaphore as a hardhat task in the hardhat semaphore plugin but @semaphore-protocol/hardhat isn't a dep of @semaphore-protocol/contracts either?

@cedoor
Copy link
Member Author

cedoor commented Jun 27, 2024

How were all the contracts deployed?

I just created a Notion document with all the steps here: https://pse-team.notion.site/Deploy-new-Semaphore-contracts-2480c6767c3c4be58a36db55e448c8af. It's a starting point to write a guide on the Semaphore documentation website.

Isn't the README in packages/contracts outdated?

It is! The right command is yarn deploy. Let me update it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants