input-journald-upload: use removeFields from config, fix include/exclude test #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WDYT @adnanrahic ? Everything except the "And also ignore messages in journald not coming from systemd services " part? We could leave the else + comment + comment out that return to disable this change? |
adnanrahic
suggested changes
Jul 1, 2021
mikolasan
force-pushed
the
journald-remove-fields
branch
from
959606a
to
6aadf20
Compare
adnanrahic
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
Looks great!
Thanks a lot for this PR @mikolasan, I'll merge it right away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some old refactoring in
64f435872178ea16357e4bcad13b3a3db63f6802the functionparseLinebecame unused and still in the code, moreoverremoveFieldsparameter from configuration was not working. This PR returns usage ofremoveFieldsas it was before the refactoring.Also fixed a bug with include/exclude parameter (hint:
log._SYSTEMD_UNIT !== log[_SYSTEMD_UNIT]).And also ignore messages in journald not coming from systemd services (I had audit and kernel syslog messages flooding my logs). This is a questionable change applied only to my setup, so please review it.