Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status code check for response to _store_bytes putcall #1089

Closed
augray opened this issue Nov 3, 2023 · 0 comments · Fixed by #1097
Closed

Add status code check for response to _store_bytes putcall #1089

augray opened this issue Nov 3, 2023 · 0 comments · Fixed by #1097
Labels
bug Something isn't working reliability

Comments

@augray
Copy link
Member

augray commented Nov 3, 2023

Right now in the API client, _store_bytes makes a put call to write data bytes after getting the signed URL to write them to. If that call fails, it will do so silently right now.

@augray augray added bug Something isn't working reliability labels Nov 3, 2023
github-merge-queue bot pushed a commit that referenced this issue Nov 13, 2023
closes #1089 

When doing a `PUT` to write artifact data, we are currently not raising
an error directly. Likely an error will still occur when something
downstream tries to *use* the artifact data (unless it's the last
artifact in a pipeline...), but we should fail more explicitly when the
error first occurs.
neutralino1 pushed a commit that referenced this issue Apr 3, 2024
closes #1089 

When doing a `PUT` to write artifact data, we are currently not raising
an error directly. Likely an error will still occur when something
downstream tries to *use* the artifact data (unless it's the last
artifact in a pipeline...), but we should fail more explicitly when the
error first occurs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reliability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant