Fix for Django 2.0 #58
Conversation
|
Thank you! I think we can drop support for Django < 1.11 for the next release. Django 1.8 will not be supported after ~April 2018 and older versions of smuggler will work just fine. Can you update your PR so it only works on Django>=1.11? This means removing the compatibility shim, updating the tox config and removing the conditional imports. If any conditional imports are still necessary please change them so the "new" import is tried first and the "old" import is in the except clause as a fallback. Your contribution is much appreciated! |
|
@jaap3 thanks for clarifications; I'm willing to improve my PR as suggested, and plan to do it in a week or so |
|
@jaap3 , I was finally able to include your suggestions into my PR. Dropping support fro Django < 1.11, nor conditional imports neither compatibility shims are needed any more, so the resulting code is cleaner. For some reason, travis keeps running checks for Django 1.8 and 1.9 configurations, even if I removed them from tox.ini. That's the reason why some tests fail. Thank you in advance for reviewing my PR. Mario |
Django < 1.6 isn't supported anymore and test discovery has improved since then
Also replace tabs with spaces
…as self.c Also fix formatting of some assertions
|
Thank you! |
| @@ -131,6 +131,12 @@ Load form (with ``SMUGGLER_FIXTURE_DIR`` configured): | |||
| Release notes | |||
| ============= | |||
|
|
|||
| Version 0.9.0 (2018-??-??) | |||
There was a problem hiding this comment.
Hey @jaap3, I was thinking in releasing version 0.8 as 1.0 (bug fixes if we ever need on 1.0 branch, then minor bugfixes releases on 1.0.x).
The current master we release as 1.1.
What do you think?
There was a problem hiding this comment.
Actually, better we release it as 0.9. We let it mature than tag it as 1.0 when it is time.
If we ever add new features at future, it should go on 1.1 and the current 0.9.x tag turns in 1.0.
|
@morlandi you have now smuggler 0.9.0 on PyPI :) |
|
Yes sir ! thankyou |
User.is_authenticated is now an attribute; backwards-compatibility support for using it as a method has been removed in Django 2.0.
See:
https://docs.djangoproject.com/en/1.11/ref/contrib/auth/#django.contrib.auth.models.User.is_authenticated
Also, unit tests have been revised, and Django 2.0 added to Tox envlist