This repository has been archived by the owner on Dec 19, 2023. It is now read-only.
Fix regression in semgrep on disabling naming of OT_Expr #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to semgrep/semgrep#923 In my previous fix I've disabled the recursion on OtherType to avoid creating cycles in the AST but doing so I've introduced some regressions in semgrep (in tests/python/misc_regression1.py) because we were not resolving correctly aliases anymore. This fixes the fix. Test plan: + /home/pad/pfff/pfff -dump_ast -naming_generic python/misc_regression1.py now shows the right id_resolved and we still do not go into infinite loop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to semgrep/semgrep#923
In my previous fix I've disabled the recursion on OtherType to avoid
creating cycles in the AST but doing so I've introduced some regressions
in semgrep (in tests/python/misc_regression1.py) because we were not
resolving correctly aliases anymore.
This fixes the fix.
Test plan:
now shows the right id_resolved
and we still do not go into infinite loop