Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to a few Go rules #2849

Merged
merged 9 commits into from
May 3, 2023
Merged

Updates to a few Go rules #2849

merged 9 commits into from
May 3, 2023

Conversation

0xDC0DE
Copy link
Contributor

@0xDC0DE 0xDC0DE commented Apr 4, 2023

No description provided.

inkz
inkz previously requested changes Apr 5, 2023
View reviewed changes
Copy link
Member

@inkz inkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good! 👍 but looks like there are errors for bot metadata checks and general rules tests

colleend
colleend suggested changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@colleend colleend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a few nits for the messages.

Thank you for doing this work and for adding in the fixes for alot of these rules 🙏

go/lang/security/audit/crypto/bad_imports.yaml Show resolved Hide resolved
go/lang/security/audit/crypto/missing-ssl-minversion.yaml Show resolved Hide resolved
@0xDC0DE
Copy link
Contributor Author

0xDC0DE commented Apr 17, 2023

Thanks @colleend, I made the requested changes.

@0xDC0DE 0xDC0DE enabled auto-merge April 17, 2023 07:39
colleend
colleend approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@colleend colleend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work!!

@enncoded enncoded closed this May 3, 2023
auto-merge was automatically disabled May 3, 2023 00:55

Pull request was closed

@enncoded enncoded reopened this May 3, 2023
@enncoded enncoded dismissed inkz’s stale review May 3, 2023 01:02

already fixed

@enncoded enncoded enabled auto-merge May 3, 2023 01:02
@enncoded enncoded merged commit 4e5f0a7 into develop May 3, 2023
6 of 8 checks passed
@enncoded enncoded deleted the go-autofixes branch May 3, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enncoded enncoded enncoded approved these changes

@colleend colleend colleend approved these changes

@inkz inkz inkz left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@0xDC0DE @inkz @enncoded @colleend