feat: update aws-network-acl-allows-public-ingress to support aws_default_network_acl #2876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cl-allows-public-ingress rule and support aws_default_network_acl
enncoded
merged commit 241e0c9
into
semgrep:semgrep-live-u21-aws-network-acl-allows-public-ingress
enncoded
pushed a commit
that referenced
this pull request
May 1, 2023
* add aws-network-acl-allows-public-ingress.yaml * add aws-network-acl-allows-public-ingress.tf * feat: update aws-network-acl-allows-public-ingress to support aws_default_network_acl (#2876) * wip: move rule files * feat: add contextual comments to terraform.aws.security.aws-network-acl-allows-public-ingress rule and support aws_default_network_acl --------- Co-authored-by: Gabrielle Singh Cadieux <gabriellesinghcadieux+github@gmail.com> Co-authored-by: Gabrielle Singh Cadieux <gabrielle.cadieux@unit21.ai>
gabriellesc
deleted the
semgrep-live-u21-aws-network-acl-allows-public-ingress
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the new
aws-network-acl-allows-public-ingressrule to support theaws_default_network_aclresource. It also adds some important contextual comments to the rule code.