Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generic Gitleak regex to remove false positives #2877

Merged
merged 6 commits into from
Apr 18, 2023

Conversation

LewisArdern
Copy link
Contributor

@LewisArdern LewisArdern commented Apr 18, 2023

This update reduces FPs in the existing rule which was ported from gitleaks.

Due to the nature of this rule, its heavy false positive.

Initial rule:

Ran 1 rule on 75023 files: 582 findings.

39.07s user 8.19s system 142% cpu 33.202 total

Updated rule:

Ran 1 rule on 73139 files: 183 findings.

71.39s user 7.98s system 171% cpu 46.262 total

@LewisArdern LewisArdern changed the title Update generic Gitlab regex to remove false positives Update generic Gitlea regex to remove false positives Apr 18, 2023
@LewisArdern LewisArdern changed the title Update generic Gitlea regex to remove false positives Update generic Gitleak regex to remove false positives Apr 18, 2023
@LewisArdern LewisArdern marked this pull request as draft April 18, 2023 22:31
@LewisArdern LewisArdern requested a review from a team April 18, 2023 22:47
@LewisArdern LewisArdern marked this pull request as ready for review April 18, 2023 22:47
@LewisArdern LewisArdern merged commit 2c3fc75 into develop Apr 18, 2023
@LewisArdern LewisArdern deleted the gitleaksUpdate branch April 18, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants