Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow choosing rules based on severity #1509

Closed
reeyaa opened this issue Aug 14, 2020 · 1 comment
Closed

Allow choosing rules based on severity #1509

reeyaa opened this issue Aug 14, 2020 · 1 comment
Labels
enhancement New feature or request feature:cli-ux good first issue Good for newcomers

Comments

@reeyaa
Copy link

reeyaa commented Aug 14, 2020

This would allow a user to choose which rule severity - ERROR, WARNING or INFO they would like to report findings on. For example, a user would only want to report findings that have severity ERROR. This could be added as an optional command line argument that can be configured by the user. By default, semgrep would use all the rules regardless of the severity rating.

Without this option, users would have to manually discard and re-add rules with a certain severity they do not/do want to report.

I imagine the outcome of this so be allowing a parameter called severity that could take different values such as:
semgrep --severity ERROR ... to only report bugs called by rules which have the severity ERROR
@dlukeomalley dlukeomalley added feature:cli-ux enhancement New feature or request labels Aug 14, 2020
@aryx aryx added the good first issue Good for newcomers label Aug 14, 2020
@kishorbhat kishorbhat mentioned this issue Nov 28, 2020
Merged
@minusworld
Copy link
Member

minusworld commented Dec 2, 2020 •
edited
Loading

Closed by #2133. Available in Semgrep 0.33.0

@bflad bflad mentioned this issue Dec 8, 2020
Closed
IagoAbal pushed a commit that referenced this issue May 14, 2024
@aryx @IagoAbal
Do not ignore OSS/ anymore in precommit (#1509)
44cf824 
test plan:
modify OSS/src/main/Main.ml indentation and run
pre-commit run -a
=> now it fixes the file

synced from 0fb525f415fcc7bfe13cda0e0c0b9b1bd86c090b
IagoAbal pushed a commit that referenced this issue May 14, 2024
@aryx @IagoAbal
Do not ignore OSS/ anymore in precommit (#1509)
b4f9587 
test plan:
modify OSS/src/main/Main.ml indentation and run
pre-commit run -a
=> now it fixes the file

synced from 0fb525f415fcc7bfe13cda0e0c0b9b1bd86c090b
IagoAbal pushed a commit that referenced this issue May 14, 2024
@aryx @IagoAbal
Do not ignore OSS/ anymore in precommit (#1509)
4019291 
test plan:
modify OSS/src/main/Main.ml indentation and run
pre-commit run -a
=> now it fixes the file

synced from 0fb525f415fcc7bfe13cda0e0c0b9b1bd86c090b
@IagoAbal IagoAbal mentioned this issue May 14, 2024
Closed
IagoAbal pushed a commit that referenced this issue May 14, 2024
@aryx @IagoAbal
Do not ignore OSS/ anymore in precommit (#1509)
0f2e93a 
test plan:
modify OSS/src/main/Main.ml indentation and run
pre-commit run -a
=> now it fixes the file

synced from 0fb525f415fcc7bfe13cda0e0c0b9b1bd86c090b
IagoAbal pushed a commit that referenced this issue May 15, 2024
@aryx @IagoAbal
Do not ignore OSS/ anymore in precommit (#1509)
943c836 
test plan:
modify OSS/src/main/Main.ml indentation and run
pre-commit run -a
=> now it fixes the file

synced from 0fb525f415fcc7bfe13cda0e0c0b9b1bd86c090b
IagoAbal pushed a commit that referenced this issue May 15, 2024
@aryx @IagoAbal
Do not ignore OSS/ anymore in precommit (#1509)
9c6c797 
test plan:
modify OSS/src/main/Main.ml indentation and run
pre-commit run -a
=> now it fixes the file

synced from 0fb525f415fcc7bfe13cda0e0c0b9b1bd86c090b
IagoAbal pushed a commit that referenced this issue May 15, 2024
@aryx @IagoAbal
Do not ignore OSS/ anymore in precommit (#1509)
0d94dc3 
test plan:
modify OSS/src/main/Main.ml indentation and run
pre-commit run -a
=> now it fixes the file

synced from 0fb525f415fcc7bfe13cda0e0c0b9b1bd86c090b
IagoAbal pushed a commit that referenced this issue May 15, 2024
@aryx @IagoAbal
Do not ignore OSS/ anymore in precommit (#1509)
467a2e2 
test plan:
modify OSS/src/main/Main.ml indentation and run
pre-commit run -a
=> now it fixes the file

synced from 0fb525f415fcc7bfe13cda0e0c0b9b1bd86c090b
IagoAbal pushed a commit that referenced this issue May 15, 2024
@aryx @IagoAbal
Do not ignore OSS/ anymore in precommit (#1509)
69bf810 
test plan:
modify OSS/src/main/Main.ml indentation and run
pre-commit run -a
=> now it fixes the file

synced from 0fb525f415fcc7bfe13cda0e0c0b9b1bd86c090b
aryx added a commit that referenced this issue May 15, 2024
@aryx
Do not ignore OSS/ anymore in precommit (#1509)
c8faaae 
test plan:
modify OSS/src/main/Main.ml indentation and run
pre-commit run -a
=> now it fixes the file

synced from 0fb525f415fcc7bfe13cda0e0c0b9b1bd86c090b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature:cli-ux good first issue Good for newcomers
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aryx @dlukeomalley @minusworld @reeyaa