Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSX] allow metavar in attribute values #2964

Closed
aryx opened this issue Apr 19, 2021 · 0 comments · Fixed by #3012
Closed

[JSX] allow metavar in attribute values #2964

aryx opened this issue Apr 19, 2021 · 0 comments · Fixed by #3012
Assignees
@aryx
Labels
lang:javascript user:internal requested only by someone within Semgrep Inc.

Comments

@aryx
Copy link
Collaborator

aryx commented Apr 19, 2021

https://staging.semgrep.dev/s/bo0r
@aryx aryx added lang:javascript user:internal requested only by someone within Semgrep Inc. labels Apr 19, 2021
@aryx aryx changed the title [JSX] allow metavar and ellipsis in attributes [JSX] allow metavar in attribute values Apr 28, 2021
@aryx aryx self-assigned this Apr 28, 2021
aryx added a commit to semgrep/pfff that referenced this issue Apr 28, 2021
@aryx
Support metavariable for JSX attribute values
1a48598 
This will help semgrep/semgrep#2964

test plan:
see in semgrep related PR
aryx added a commit that referenced this issue Apr 28, 2021
@aryx
[JSX] support ... in JSX text body and $XX for attribute values
2d00163 
This closes #2964
This closes #2963

test plan:
test files included
make test
@aryx aryx mentioned this issue Apr 28, 2021
Merged
1 task
aryx added a commit that referenced this issue Apr 28, 2021
@aryx
[JSX] support ... in JSX text body and $XX for attribute values (#3012)
45506b9 
This closes #2964
This closes #2963

test plan:
test files included
make test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aryx aryx

Labels
lang:javascript user:internal requested only by someone within Semgrep Inc.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[JSX] support ... in JSX text body and $XX for attribute values semgrep/semgrep
1 participant
@aryx