Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kotlin] support ellipsis in class body #4141

Closed
1 of 3 tasks
colleend opened this issue Oct 26, 2021 · 3 comments · Fixed by #4174
Closed
1 of 3 tasks

[Kotlin] support ellipsis in class body #4141

colleend opened this issue Oct 26, 2021 · 3 comments · Fixed by #4174
Assignees
@aryx
Labels
bug Something isn't working lang:kotlin

Comments

@colleend
Copy link
Contributor

Describe the bug
The Kotlin interface syntax (class x: y {...}) does not parse as a valid pattern.

To Reproduce
https://semgrep.dev/s/oYpN

Expected behavior
Would expect this pattern to parse.

What is the priority of the bug to you?

  • P0: blocking your adoption of Semgrep or workflow
  • P1: important to fix or quite annoying
  • P2: regular bug that should get fixed
@colleend colleend added bug Something isn't working lang:kotlin labels Oct 26, 2021
@aryx aryx self-assigned this Oct 26, 2021
@colleend
Copy link
Contributor Author

I can also take a look into these if you're focusing on the newline bug!

@aryx
Copy link
Collaborator

aryx commented Oct 28, 2021

I think it's because "..." is not allowed yet inside a class body.
I'll fix it. I also need to update to the latest fwcd with your latest improvoements (yeah, 90 -> 93%!)

@aryx aryx changed the title Kotlin pattern parsing error in interfaces [Kotlin] support ellipsis in class body Oct 28, 2021
aryx added a commit that referenced this issue Oct 28, 2021
@aryx
[Kotlin] use latest semgrep-kotlin and support more ellipsis
af80d2d 
This closes #4141
This closes #4140

test plan:
test file included
@aryx aryx mentioned this issue Oct 28, 2021
Merged
3 tasks
@colleend
Copy link
Contributor Author

awesome, thanks for doing this!

aryx added a commit that referenced this issue Oct 29, 2021
@aryx
[Kotlin] use latest semgrep-kotlin and support more ellipsis (#4174)
7d2608c 
* [Kotlin] use latest semgrep-kotlin and support more ellipsis

This closes #4141
This closes #4140

test plan:
test file included

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aryx aryx

Labels
bug Something isn't working lang:kotlin
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Kotlin] use latest semgrep-kotlin and support more ellipsis semgrep/semgrep
2 participants
@aryx @colleend