Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Alpha: public function causes invalid pattern #4262

Closed
1 of 3 tasks
dee-see opened this issue Nov 11, 2021 · 3 comments · Fixed by #4297
Closed
1 of 3 tasks

PHP Alpha: public function causes invalid pattern #4262

dee-see opened this issue Nov 11, 2021 · 3 comments · Fixed by #4297
Assignees
@aryx
Labels
lang:php

Comments

@dee-see
Copy link
Contributor

dee-see commented Nov 11, 2021 •
edited

Describe the bug

Seems like having public in the pattern causes an error

To Reproduce

https://semgrep.dev/s/krg2

Expected behavior

It should work :)

Screenshots
If applicable, add screenshots to help explain your problem.

What is the priority of the bug to you?

  • P0: blocking your adoption of Semgrep or workflow
  • P1: important to fix or quite annoying
  • P2: regular bug that should get fixed

Environment
semgrep.dev
@aryx aryx self-assigned this Nov 12, 2021
@aryx aryx added the lang:php label Nov 12, 2021
@dee-see
Copy link
Contributor Author

dee-see commented Nov 13, 2021

Modified the snippet to include the opening PHP tag (my bad) but it still doesn't work

https://semgrep.dev/s/krg2

aryx added a commit to semgrep/pfff that referenced this issue Nov 17, 2021
@aryx
[PHP] allow public method pattern for semgrep
384ead3 
This should help semgrep/semgrep#4262

test plan:
see related PR in semgrep
aryx added a commit that referenced this issue Nov 17, 2021
@aryx
[PHP] allow public method pattern for semgrep
a48a693 
This closes #4262

test plan:
test file included
@aryx aryx mentioned this issue Nov 17, 2021
Merged
3 tasks
aryx added a commit that referenced this issue Nov 17, 2021
@aryx
[PHP] allow public method pattern for semgrep (#4297)
9221d23 
* [PHP] allow public method pattern for semgrep

This closes #4262

test plan:
test file included

* changelog
@aryx
Copy link
Collaborator

aryx commented Nov 17, 2021

Should work in the next release (or if you use develop).

@dee-see
Copy link
Contributor Author

dee-see commented Nov 17, 2021

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aryx aryx

Labels
lang:php
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[PHP] allow public method pattern for semgrep semgrep/semgrep
2 participants
@aryx @dee-see