Add support for SCA Elixir manifest/lockfile parsing #10022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR checklist:
If you're unsure about any of this, please see: |
jarrydlee
force-pushed
the
jl/elixir-mix-parser
branch
from
51c413d
to
6d68a2a
Compare
semgrep-compare-github-q5w31 resultsRan benchmark on 38 repositories Whole benchmark is 2.1% slower (a bit of noise is expected) Relative speed improvement is 0.98 on average
Relative memory improvement is 1.00 on average |
jarrydlee
force-pushed
the
jl/elixir-mix-parser
branch
from
6d68a2a
to
11cf946
Compare
semgrep-compare-github-rg4hf resultsRan benchmark on 38 repositories Whole benchmark is 1.5% faster (a bit of noise is expected) Relative speed improvement is 1.05 on average
Relative memory improvement is 1.00 on average |
mmcqd
approved these changes
Mar 28, 2024
mmcqd
reviewed
Mar 28, 2024
|
Don't worry about the failing build-test-core-x86-ocaml5 job |
jarrydlee
added a commit
that referenced
this pull request
Apr 2, 2024
In #10022, Elixir incorrectly used `Mix` as the ecosystem instead of `Hex`. Mix is an Elixir build tool, where Hex is the ecosystem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supply Chain is adding support for Elixir when using Mix. This adds lockfile and manifest parsing to extract relevant package information used by SSC.
Since elixir is a pro-only language, e2e testing cannot be executed since OSS semgrep cannot parse Elixir. Instead, testing for the full manifest/lockfiles have been included.