New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support codeql #10031
feat: support codeql #10031
Conversation
📸 The pytest shapshots changed in your PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except I would rather you use unsafe_fake_tok
a lot less. I didn't include a comment on each one, but I think in almost every place you could have used fake_tok_loc
instead with minimal hassle. Given that this isn't the most important language to us it's ok with me if you merge this without addressing that.
PR checklist:
If you're unsure about any of this, please see: |
What:
This PR introduces the QL language (used by CodeQL) to Semgrep.
Why:
It's funny.
How:
Did the generic translation, augmented by an intermediate AST to clarify things, and added some tests.
Closes SAF-947