Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support callv and proxies for lsp.js #10172

Merged
merged 10 commits into from
Apr 29, 2024
Merged

fix: support callv and proxies for lsp.js #10172

merged 10 commits into from
Apr 29, 2024

Commits on Apr 26, 2024

  1. fix: support callv and proxies for lsp.js 

    Previously we added support for proxies in #9994. But it broke LSP.js
networking as we were forced to use callv to support proxies as a
workaround, and callv isn't supported in cohttp-jsoo!. So we have to
patch callv and patch our XHR js library to enable proxies for this
stuff. I'm going to try and make a bunch of PRs to cohttp and ca-certs
etc to fix this upstream, but for now we have this fix
    @ajbt200128
    ajbt200128 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    09df1e2 View commit details
    Browse the repository at this point in the history

  2. add test for e2e making REAL network requests

    @ajbt200128
    ajbt200128 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    0e34a04 View commit details
    Browse the repository at this point in the history

  3. const

    @ajbt200128
    ajbt200128 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    43c839e View commit details
    Browse the repository at this point in the history

  4. fix tests 

    normal shared cant have cohttp in it because then it expects xhr.
There's xhr in the browser so it'd be weird to include it regardless of node
    @ajbt200128
    ajbt200128 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    7b28bfd View commit details
    Browse the repository at this point in the history

  5. fix/cleanup tests

    @ajbt200128
    ajbt200128 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    642a91f View commit details
    Browse the repository at this point in the history

  6. cleanup and comments

    @ajbt200128
    ajbt200128 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f5240aa View commit details
    Browse the repository at this point in the history

  7. remove thing

    @ajbt200128
    ajbt200128 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    5563ce1 View commit details
    Browse the repository at this point in the history

  8. oops

    @ajbt200128
    ajbt200128 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    7197b88 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. merge develop

    @ajbt200128
    ajbt200128 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    b52058f View commit details
    Browse the repository at this point in the history

  2. I'm bad at merging

    @ajbt200128
    ajbt200128 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ee73e8f View commit details
    Browse the repository at this point in the history