Convert tree-sitter parse error exn to Parse_info.Parsing_error #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is already some code to automatically intercept Parse_info exns to display their location, so better to use a consistent scheme across pfff and tree-sitter parsers. test plan: ``` (semgrep) pad@yrax:~/semgrep/tests/OTHER/parsing_errors$ semgrep -l ts -e 'FOO' . warn: parse error --> err.ts:2 2 | return 1+ | ^^^^^^^^^ = help: If the code appears to be valid, this may be a semgrep bug. Could not parse err.ts as ts Warnings exist. Run with `--strict` to turn warnings into errors. ``` better than the previous error that was always reported on the first line. This also improves error location for the errors reported in #1713
mjambon
approved these changes
Oct 1, 2020
| let loc = mk_tree_sitter_error ts_error in | ||
| let info = { PI.token = PI.OriginTok loc; transfo = PI.NoTransfo } in | ||
| raise (PI.Parsing_error info) | ||
| end else raise exn |
There was a problem hiding this comment.
To get the constructor, you can do Printexc.exn_slot_name exn (since ocaml 4.02). But I don't see how to do the rest without Obj, other than catching the exception in the child (or make the parser return an Ok/Error).
There was a problem hiding this comment.
yep, the parser could return an algebraic data type. Only exn (open variants) have this marshalling issue.
Still, I like this hacky solution :)
aryx
commented
Oct 1, 2020
| let loc = mk_tree_sitter_error ts_error in | ||
| let info = { PI.token = PI.OriginTok loc; transfo = PI.NoTransfo } in | ||
| raise (PI.Parsing_error info) | ||
| end else raise exn |
There was a problem hiding this comment.
yep, the parser could return an algebraic data type. Only exn (open variants) have this marshalling issue.
Still, I like this hacky solution :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already some code to automatically intercept Parse_info exns
to display their location, so better to use a consistent scheme
across pfff and tree-sitter parsers.
test plan:
better than the previous error that was always reported on the first line.
This also improves error location for the errors reported in
#1713