Fix stack overflows #1986
Merged
Fix stack overflows #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 6, 2020 18:31
Allows a semgrep scan on all the files of the semgrep repo without crashing, on Ubuntu/Linux with default 'ulimit -s' setting (8 MB). Fixes #1944
aryx
approved these changes
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested on the joke calculator file we had elsewhere in the semgrep repo (
my_first_calculator.py) since it was giving us stack overflows when scanning the semgrep repo itself. After reducing my stack limit (down toulimit -s 50), I reached a point where spacegrep was fine but unix utilities started to crash (lessandbash(I think)).I added
make examplesto the CI tests, which should do the job of finding future stack overflows.Fixes #1944