New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust: Support top-level statements #2910
Conversation
Once you modify the rust grammar, you need to pull the updated generated ocaml code for it in the semgrep/semgrep-core/src/tree-sitter-lang/semgrep-rust/ (it's a submodule that is automatically updated from the latest rust semgrep grammar). |
.gitmodules
Outdated
@@ -36,7 +36,7 @@ | |||
url = https://github.com/returntocorp/semgrep-ruby | |||
[submodule "semgrep-core/tree-sitter-lang/semgrep-rust"] | |||
path = semgrep-core/src/tree-sitter-lang/semgrep-rust | |||
url = https://github.com/returntocorp/semgrep-rust |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you revert this back to use our semgrep-rust?
…o rust-toplevel-statements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! Thanks.
As discussed on Slack, the
crate::foo();
unit test inexpression.rs
currently fails.Other PR: semgrep/ocaml-tree-sitter-semgrep#177
PR checklist: