Add required executionSuccessful attribute to SARIF output #2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-engledew
force-pushed
the
simon-engledew/missing-sarif-properties
branch
from
a268161
to
e1390f4
Compare
underyx
approved these changes
Apr 26, 2021
|
Thank you again @simon-engledew! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢 Hello! This is a follow up to: #2888 馃檱 鉂わ笍
I realised after fixing the first issue the online Validator actually highlights a few others 馃う
Of them, only one appears to be a specification violation:
A missing
executionSuccessfulproperty: https://docs.oasis-open.org/sarif/sarif/v2.1.0/csprd01/sarif-v2.1.0-csprd01.html#_Ref8832061You can see this by taking
semgrep/tests/e2e/snapshots/test_check/test_sarif_output/results.sarifand uploading it to the online SARIF validator.Once you fix this a few others appear (A missing
informationUriproperty: https://docs.oasis-open.org/sarif/sarif/v2.1.0/csprd01/sarif-v2.1.0-csprd01.html#_Toc9244329 and rule "id" not being equal to "name"). As these are optional I wont fix them in this PR - especially as dropping the name attribute may have unintended consequences.PR checklist: