Handle regexp parse errors gracefully #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create an exception for regexp parse errors with good error messages and handle it python side Test plan: In semgrep/semgrep/tests/e2e, run semgrep --config rules/regex-invalid.yaml --optimizations You should see running 1 rules... Invalid regexp in rule: '(abc': missing ) at position 4
|
Failures seem to be due to semgrep/semgrep-rules@1e44447; merging #3268 will fix |
aryx
approved these changes
Jun 4, 2021
| @@ -28,6 +28,9 @@ exception InvalidLanguageException of string * string | |||
| exception InvalidPatternException of string * string * string * string | |||
|
|
|||
| (*e: exception [[Parse_rules.InvalidPatternException]] *) | |||
|
|
|||
| exception InvalidRegexpException of string * string | |||
There was a problem hiding this comment.
By the way, I don't think I introduced those exceptions, but there's no need to have them suffixed by Exception.
We know it's an exception :)
(It's fine in this PR because it's good to be consistent, but we should fix those later).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an exception for regexp parse errors with good error messages and handle it python side
Test plan:
In semgrep/semgrep/tests/e2e, run semgrep --config rules/regex-invalid.yaml --optimizations
You should see
running 1 rules...
Invalid regexp in rule: '(abc': missing ) at position 4
PR checklist: