Prevent spacegrep from skipping files #3418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjambon
force-pushed
the
mj-skipping-files
branch
from
48a44ab
to
cebe902
Compare
IagoAbal
reviewed
Jun 29, 2021
| - generic mode on Markdown files with very long lines will now work (#2987) | ||
|
|
||
| ### Changed | ||
| - generic mode: files that don't look like nicely-indented programs |
There was a problem hiding this comment.
I couldn't see any check being removed from the code, although perhaps it's a very small change and I'm missing it since there are many other changes to docs etc.
There was a problem hiding this comment.
It's the --force option that was added to the spacegrep command line... and the option in question was already implemented by spacegrep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
spacegrepcommand line can take a single file or folders. It skips files silently based on a heuristic that guess whether the files look like programs, based on average line length. This causes markdown files with very long lines to be skipped. The--forceoption of spacegrep disables this heuristic.I added test to check the performance on big and/or binary files. It's not that great and will depend on the pattern. Semgrep uses a 10MB limit for all targets, which should be fine for programs with proper indentation but will cause problems on minified files or some binary files that don't contain newlines. Rule authors must ensure that paths are filtered by extension like this rule. If that's already the case in practice, then we're good.
Fixes #2987
PR checklist: