Scala: Parse by name types in function arguments

[mmcqd]

We can now parse types like (=> Int) => Int

Test plan: make test (see added test)

PR checklist:

• Documentation is up-to-date
• Changelog is up-to-date
• Change has no security implications (otherwise, ping security team)

[linear]

PA-158 [Scala] Parsing error

Describe the bug

src/main/scala/Main.scala:10:27: Syntax error
Raised at file "src/parsing/Parse_target.ml", line 174, characters 23-26
Called from file "src/cli/Main.ml", line 1114, characters 17-60
Called from file "src/pfff/h_program-lang/Error_code.ml", line 399, characters 4-8

Uncaught exception:

  Parse_info.Parsing_error(_)

Raised at file "src/parsing/Parse_target.ml", line 174, characters 23-26
Called from file "src/cli/Main.ml", line 1114, characters 17-60

Code:

import org.slf4j.{Logger, LoggerFactory, MDC}
import zio.FiberRef
import scala.jdk.CollectionConverters._

object Logging {
  trait Service {
  }
}

class Slf4jLogger(logger: (=> AnyRef) => Logger, mdcContext: FiberRef[Map[String, String]]) extends Logging.Service {
  val sync = 123

}
object Main extends App {
  println("Hq")
}

To Reproduce
Analyze attached code fragment

Expected behavior
file successfully parsed

What is the priority of the bug to you?

• P0: blocking your adoption of Semgrep or workflow
• P1: important to fix or quite annoying
• P2: regular bug that should get fixed

Environment
docker

View original issue in GitHub

---

[aryx]

woohoo!

[aryx]

Do you know how much it improves our parsing stats for Scala?

[mmcqd]

Do you know how much it improves our parsing stats for Scala?

We went from 89.6 to 90.0, so not massive, but measurable.