taint-mode: Check variables as if they were subexpressions #4323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryx
approved these changes
Nov 30, 2021
If the LHS of `->foo` was a sink, and we encountered `x->foo` where `x` was a variable, we did not report a finding even if `x` was tainted. We were not checking whether `x` was in a sink position. Although they are not represented as such in the IL, variables are themselves subexpressions, so we must check whether they are sinks or sanitized. Closes #4320 test plan: make test # test included
|
🔥 Potential speedup in benchmark semgrep.bench.apache.std: -44.7% (-6.902 s) 14 benchmarks, 0.6% faster on average. Individual deviations greater than 20% from the baseline are reported. An individual performance degradation of over 30% or a global degradation of over 7% is an error and will block the pull request. See run output for full results ('Show all checks' > 'Tests / semgrep benchmark tests' 'Details'). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the LHS of
->foowas a sink, and we encounteredx->foowherexwas a variable, we did not report a finding even if
xwas tainted. Wewere not checking whether
xwas in a sink position.Although they are not represented as such in the IL, variables are
themselves subexpressions, so we must check whether they are sinks or
sanitized.
Closes #4320
test plan:
make test # test included
PR checklist: