feat!: type coercions for Terraform #6917
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR adds in coercions from literals of bools, ints, and floats to strings, in the matching engine.
Why:
This is how Terraform works, and it was requested by a user: #6898
How:
I added a wrapper for
m_literal
, which first checks if the language ishcl
. If so, then it does the coercions on the necessary cases. Otherwise, it will defer to the originalm_literal
, now namedm_literal_inner
.Test plan:
make test
Closes #6898
PR checklist:
If you're unsure on any of this, please see: