Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Build and push rootless docker container (#8572)" #8615

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

aryx
Copy link
Collaborator

@aryx aryx commented Sep 2, 2023

This reverts commit ff099a3.

PR checklist:

  • Purpose of the code is evident to future readers
  • Tests included or PR comment includes a reproducible test plan
  • Documentation is up-to-date
  • A changelog entry was added to changelog.d for any user-facing change
  • Change has no security implications (otherwise, ping security team)

If you're unsure about any of this, please see:

@aryx aryx requested review from a team and amchiclet and removed request for a team September 2, 2023 06:45
@aryx
Copy link
Collaborator Author

aryx commented Sep 2, 2023

see #8572

@aryx aryx merged commit 3d835af into develop Sep 2, 2023
18 of 19 checks passed
@aryx aryx deleted the revert_nonroot branch September 2, 2023 06:50
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

🚫 The whole benchmark suite is too slow: +7.8% (+1.078 s)

14 benchmarks, 7.8% slower on average.

Individual deviations greater than 20% from the baseline are reported. An individual performance degradation of over 30% or a global degradation of over 7% is an error and will block the pull request. See run output for full results ('Show all checks' > 'Tests / semgrep benchmark tests' 'Details').

cgdolan added a commit that referenced this pull request Sep 5, 2023
cretoxyrhina pushed a commit to cretoxyrhina/semgrep that referenced this pull request Oct 17, 2023
…grep#8615)

This reverts commit ff099a3.


PR checklist:

- [x] Purpose of the code is [evident to future
readers](https://semgrep.dev/docs/contributing/contributing-code/#explaining-code)
- [x] Tests included or PR comment includes a reproducible test plan
- [x] Documentation is up-to-date
- [x] A changelog entry was [added to
changelog.d](https://semgrep.dev/docs/contributing/contributing-code/#adding-a-changelog-entry)
for any user-facing change
- [x] Change has no security implications (otherwise, ping security
team)

If you're unsure about any of this, please see:

- [Contribution
guidelines](https://semgrep.dev/docs/contributing/contributing-code)!
- [One of the more specific guides located
here](https://semgrep.dev/docs/contributing/contributing/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant