Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sg alias for compliance with the shadow-utils #9642

Merged
merged 3 commits into from Jan 23, 2024
Merged

Remove sg alias for compliance with the shadow-utils #9642

merged 3 commits into from Jan 23, 2024

Conversation

zzeleznick
Copy link
Contributor

Description

This PR removes the sg alias that we introduced in #9117 as a convenience command.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2024 •
edited by zzeleznick

PR checklist:

  • Purpose of the code is evident to future readers
  • Tests included or PR comment includes a reproducible test plan
  • Documentation is up-to-date
  • A changelog entry was added to changelog.d for any user-facing change
  • Change has no security implications (otherwise, ping security team)

If you're unsure about any of this, please see:

@zzeleznick zzeleznick requested a review from aryx January 23, 2024 00:45
@aryx aryx merged commit e9e6031 into develop Jan 23, 2024
51 checks passed
@aryx aryx deleted the rm-sg branch January 23, 2024 08:09
@noraj
Copy link

noraj commented Feb 6, 2024

So it fixes #9571

@noraj noraj mentioned this pull request Feb 6, 2024
Closed
3 tasks
@aryx
Copy link
Collaborator

aryx commented Feb 6, 2024

correct. Thx for reporting (and closing) the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryx aryx aryx approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zzeleznick @noraj @aryx