Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add the ability to specify at the test creation time the snapshot location #41

Open
aryx opened this issue Mar 21, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@aryx
Copy link
Contributor

aryx commented Mar 21, 2024

Right now the snapshots are stored in a cryptic directory (e.g., tests/snapshots/6ag6fdedfr/) which makes it hard
when reviewing PRs with tests to know to which test a snapshot expected output correspond to.

It would be good to have the snapshot and the test in the same directory so one could write

Test.create "testing tests/target/c/foo.c" ~checked_output:Testo.Stdout("tests/target/c/foo.stdout") (fun () ->
. ..
)

I think @neuroo was recently complaining about that.

@mjambon
Copy link
Member

mjambon commented Mar 21, 2024

I think it would easy to add to the current implementation. I don't see a real downside.

@mjambon mjambon added the enhancement New feature or request label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants