Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeoCoordinates 0,0 lead to unexpected behavior #825

Closed
etiennedi opened this issue Apr 4, 2019 · 4 comments · Fixed by #1121
Closed

GeoCoordinates 0,0 lead to unexpected behavior #825

etiennedi opened this issue Apr 4, 2019 · 4 comments · Fixed by #1121
Assignees
@etiennedi
Labels
Bad UX Issues that frustrate our Users bug External Dependency Resolving this depends on sth. external. If the dependency is open-source, we might consider a PR.

Comments

@etiennedi
Copy link
Member

From slack, as found by @dljcollette

is seems when I post a thing with geoCoordinates that are latitude and/or longitude of 0 seem to return an empty object. Could if be that a value 0 is seen as null and therefore doesn’t return an object with latitude and longitude?
@etiennedi etiennedi added Bad UX Issues that frustrate our Users bug labels Apr 4, 2019
@etiennedi
Copy link
Member Author

Most likely related to swagger-api/swagger-codegen#7391 (comment)

I'll try this out.

@etiennedi
Copy link
Member Author

Unfortunately the fix proposed there does not work for number/float32 types as demonstrated in swagger-api/swagger-codegen#7391 (comment)

CC @dljcollette @bobvanluijt

@etiennedi etiennedi added the External Dependency Resolving this depends on sth. external. If the dependency is open-source, we might consider a PR. label Apr 5, 2019
@etiennedi etiennedi self-assigned this Apr 5, 2019
@stale
Copy link

stale bot commented Apr 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 6, 2020
@etiennedi etiennedi removed the wontfix label Apr 15, 2020
@etiennedi
Copy link
Member Author

This issue is about a year old and was impossible to fix back then. Time to reevaluate if we can fix it today.

@etiennedi etiennedi mentioned this issue Apr 15, 2020
Closed
19 tasks
etiennedi added a commit that referenced this issue Apr 15, 2020
@etiennedi
gh-825 fix omitempty issue on geo props by forcing pointer type
da3d702
etiennedi added a commit that referenced this issue Apr 15, 2020
@etiennedi
gh-825 prevent regression through new journey test
67c6dc9
@etiennedi etiennedi mentioned this issue Apr 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etiennedi etiennedi

Labels
Bad UX Issues that frustrate our Users bug External Dependency Resolving this depends on sth. external. If the dependency is open-source, we might consider a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix/geo coordinates zero weaviate/weaviate
1 participant
@etiennedi