Bugfix: Deleting a referenced class panics on GQL schema rebuild #2189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a class is deleted from weaviate which is referenced as a ref prop by another class, and the graphql schema is rebuilt, it panics, resulting in a total loss of GQL provider.
With this patch, all of these offending ref props are skipped during schema rebuild. This means no panic, and all other properties of the class containing these invalid ref prop(s) can still be queried.
What's being changed:
ErrRefToNonexistentClass
so the local get builder knows with certainty when the*Schema.FindPropertyDataType
is failing for this reasonReview checklist