-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for partial orders of L/R-classes #415
Merged
james-d-mitchell
merged 3 commits into
semigroups:master
from
wilfwilson:partial-order-of-l-r-classes
May 20, 2022
Merged
Add support for partial orders of L/R-classes #415
james-d-mitchell
merged 3 commits into
semigroups:master
from
wilfwilson:partial-order-of-l-r-classes
May 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54010e3
to
092ee61
Compare
522ca84
to
0b89ac3
Compare
0b89ac3
to
89d8503
Compare
89d8503
to
553c3e9
Compare
553c3e9
to
62a55c5
Compare
7c37b3c
to
b01d162
Compare
b01d162
to
4dbe97d
Compare
4dbe97d
to
d14b2ba
Compare
d14b2ba
to
c622513
Compare
4e48ec9
to
83883d9
Compare
And add methods for partial order of L/R-classes
5a2b268
to
1e811b7
Compare
I've just rebased this onto the most recent |
Thanks @james-d-mitchell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have
PartialOrderOfDClasses
andMaximalDClasses
; it would be nice if we had similar forL
andR
. It would be useful for my code to do with direct products, in particular.I've added methods for enumerable semigroups. I feel like it should be simple to do something clever for acting semigroups, but maybe not.
I still need to polish this PR (more manual examples and tests), so it's not ready to be merged, but I'm creating this PR to spur me to finish it, and possibly as a way to ask for advice.