Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for partial orders of L/R-classes #415

Merged

Conversation

wilfwilson
Copy link
Collaborator

We already have PartialOrderOfDClasses and MaximalDClasses; it would be nice if we had similar for L and R. It would be useful for my code to do with direct products, in particular.

I've added methods for enumerable semigroups. I feel like it should be simple to do something clever for acting semigroups, but maybe not.

I still need to polish this PR (more manual examples and tests), so it's not ready to be merged, but I'm creating this PR to spur me to finish it, and possibly as a way to ask for advice.

@wilfwilson wilfwilson added 3.1 do not merge Label for PR that should not be merged labels Nov 15, 2017
@james-d-mitchell james-d-mitchell added the new-feature A label for PRs that contain new features label Apr 2, 2018
@wilfwilson wilfwilson force-pushed the partial-order-of-l-r-classes branch 2 times, most recently from 522ca84 to 0b89ac3 Compare September 10, 2018 20:39
@wilfwilson wilfwilson added the WIP Label for PRs that are Works In Progress (WIP) label Nov 24, 2018
@wilfwilson wilfwilson force-pushed the partial-order-of-l-r-classes branch 2 times, most recently from 7c37b3c to b01d162 Compare June 5, 2019 16:08
@wilfwilson wilfwilson force-pushed the partial-order-of-l-r-classes branch from 4dbe97d to d14b2ba Compare May 20, 2021 09:52
@james-d-mitchell james-d-mitchell force-pushed the partial-order-of-l-r-classes branch 2 times, most recently from 4e48ec9 to 83883d9 Compare March 7, 2022 13:04
@james-d-mitchell james-d-mitchell removed the do not merge Label for PR that should not be merged label May 20, 2022
@james-d-mitchell
Copy link
Collaborator

I've just rebased this onto the most recent master, if the CI passes, I think I'll merge it, because it is essentially complete, and has been rotting for too long already (also I think it adds a useful feature!)

@james-d-mitchell james-d-mitchell removed the WIP Label for PRs that are Works In Progress (WIP) label May 20, 2022
@james-d-mitchell james-d-mitchell merged commit f4808de into semigroups:master May 20, 2022
@wilfwilson
Copy link
Collaborator Author

Thanks @james-d-mitchell

@wilfwilson wilfwilson deleted the partial-order-of-l-r-classes branch May 20, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature A label for PRs that contain new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants